Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add badge #627

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add badge #627

wants to merge 2 commits into from

Conversation

hw1004
Copy link

@hw1004 hw1004 commented Oct 18, 2023

Description

Info

Name Category Background Color Logo Color
Tableau ORM #E97627 #ffffff

Preview

Badge url
Tableau ![Tableau](https://img.shields.io/badge/Tableau-E97627?style=for-the-badge&logo=Tableau&logoColor=white)

@kohasummons kohasummons added the changes-requested Request changes label Dec 15, 2023
kohasummons
kohasummons requested changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@kohasummons kohasummons left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heyyo! Super contribution @hw1004. This seems like two contributions in one PR. We try to have a One PR, One Contribution flow; So that means we have to separate the add badge contribution from the table of content edit contribution.

Also, we moved away from adding emojis to the TOC because I think that affects the collapsible feature we've got going on. Can you fix that, if not, we prefer the TOC without emojis.

Let's gooooo. Looking forward to your response.

@hw1004 hw1004 closed this Dec 15, 2023
@hw1004 hw1004 reopened this Dec 15, 2023
@hw1004 hw1004 closed this Dec 15, 2023
@hw1004 hw1004 reopened this Dec 15, 2023
@hw1004
Copy link
Author

hw1004 commented Dec 15, 2023 •
edited
Loading

Heyy @kohasummons thanks for the comment. I was just wondering why the emojis keep showing up in the TOC part since I only intended to add a new badge. I just realized that it was because of the auto-generation of TOC on vscode. Consequently, I made it to remove all emojis from the TOC. So the only change is the badge part. Please let me know if it needs other changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kohasummons kohasummons kohasummons requested changes

Assignees
No one assigned
Labels
changes-requested Request changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hw1004 @kohasummons